Development

docker/routlin-dash/app/action_apply_ddns_providers.py

@@ -1,12 +1,12 @@
 from flask import Blueprint, request, redirect, flash
 from auth import require_level
-import json
+from config_utils import load_core, save_core
 import sanitize
 import validation as validate
 
 bp = Blueprint('action_apply_ddns_providers', __name__)
 
-DDNS_FILE = '/configs/ddns.json'
+VIEW = '/view/view_ddns'
 
 
 @bp.route('/action/add_ddns_provider', methods=['POST'])
@@ -14,24 +14,17 @@ DDNS_FILE = '/configs/ddns.json'
 def add_ddns_provider():
     provider_type = sanitize.filtervalue(request.form.get('provider', ''), validate.VALID_DDNS_PROVIDERS)
     description   = sanitize.description(request.form.get('description', ''))
-    hostnames = sanitize.domainlist(request.form.get('hostnames', '').splitlines())
+    hostnames     = sanitize.domainlist(request.form.get('hostnames', '').splitlines())
 
     if not description:
         flash('Description is required.', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
     if not hostnames:
         flash('At least one hostname is required.', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
     if not provider_type:
         flash('Unknown provider type.', 'error')
-        return redirect('/view/view_ddns')
-
-    try:
-        with open(DDNS_FILE) as f:
-            data = json.load(f)
-    except Exception as ex:
-        flash(f'Could not read config: {ex}', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
 
     entry = {
         'description': description,
@@ -45,15 +38,11 @@ def add_ddns_provider():
     else:
         entry['api_token'] = request.form.get('api_token', '').strip()
 
-    data.setdefault('providers', []).append(entry)
-
-    try:
-        with open(DDNS_FILE, 'w') as f:
-            json.dump(data, f, indent=2)
-        flash(f'DDNS provider "{description}" added.', 'success')
-    except Exception as ex:
-        flash(f'Could not save config: {ex}', 'error')
-    return redirect('/view/view_ddns')
+    core = load_core()
+    core.setdefault('ddns', {}).setdefault('providers', []).append(entry)
+    save_core(core)
+    flash(f'DDNS provider "{description}" added.', 'success')
+    return redirect(VIEW)
 
 
 @bp.route('/action/edit_ddns_provider', methods=['POST'])
@@ -63,29 +52,22 @@ def edit_ddns_provider():
         row_index = int(request.form.get('row_index', -1))
     except (TypeError, ValueError):
         flash('Invalid row index.', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
 
     provider_type = sanitize.filtervalue(request.form.get('provider', ''), validate.VALID_DDNS_PROVIDERS)
     description   = sanitize.description(request.form.get('description', ''))
-    hostnames_raw = request.form.get('hostnames', '')
+    hostnames     = [h.strip() for h in request.form.get('hostnames', '').splitlines() if h.strip()]
     enabled       = request.form.get('enabled') == 'on'
-    hostnames     = [h.strip() for h in hostnames_raw.splitlines() if h.strip()]
 
     if not provider_type:
         flash('Unknown provider type.', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
 
-    try:
-        with open(DDNS_FILE) as f:
-            data = json.load(f)
-    except Exception as ex:
-        flash(f'Could not read config: {ex}', 'error')
-        return redirect('/view/view_ddns')
-
-    providers = data.get('providers', [])
+    core      = load_core()
+    providers = core.setdefault('ddns', {}).setdefault('providers', [])
     if row_index < 0 or row_index >= len(providers):
         flash('Invalid provider index.', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
 
     entry = {
         'description': description,
@@ -100,15 +82,9 @@ def edit_ddns_provider():
         entry['api_token'] = request.form.get('api_token', '').strip()
 
     providers[row_index] = entry
-    data['providers'] = providers
-
-    try:
-        with open(DDNS_FILE, 'w') as f:
-            json.dump(data, f, indent=2)
-        flash('DDNS provider updated.', 'success')
-    except Exception as ex:
-        flash(f'Could not save config: {ex}', 'error')
-    return redirect('/view/view_ddns')
+    save_core(core)
+    flash('DDNS provider updated.', 'success')
+    return redirect(VIEW)
 
 
 @bp.route('/action/delete_ddns_provider', methods=['POST'])
@@ -118,27 +94,15 @@ def delete_ddns_provider():
         row_index = int(request.form.get('row_index', -1))
     except (TypeError, ValueError):
         flash('Invalid row index.', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
 
-    try:
-        with open(DDNS_FILE) as f:
-            data = json.load(f)
-    except Exception as ex:
-        flash(f'Could not read config: {ex}', 'error')
-        return redirect('/view/view_ddns')
-
-    providers = data.get('providers', [])
+    core      = load_core()
+    providers = core.setdefault('ddns', {}).setdefault('providers', [])
     if row_index < 0 or row_index >= len(providers):
         flash('Invalid provider index.', 'error')
-        return redirect('/view/view_ddns')
+        return redirect(VIEW)
 
     del providers[row_index]
-    data['providers'] = providers
-
-    try:
-        with open(DDNS_FILE, 'w') as f:
-            json.dump(data, f, indent=2)
-        flash('DDNS provider deleted.', 'success')
-    except Exception as ex:
-        flash(f'Could not save config: {ex}', 'error')
-    return redirect('/view/view_ddns')
+    save_core(core)
+    flash('DDNS provider deleted.', 'success')
+    return redirect(VIEW)